Fix windows compile: fix size_t vs. int mismatch

Fix windows compile: fix size_t vs. int mismatch

As indicated by:
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/63417/steps/compile%20%28with%20patch%29/logs/stdio

R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b29338d126125d96d63817af1d80a64ea929ffae

[Tom Sepez, 2015-06-02 22:13:52]

Lei, for review.  This is blocking the current PDFium Roll.

[Lei Zhang, 2015-06-02 22:17:05]

lgtm

https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:586: // By enabling predicatble mode, V8 won't post any
background tasks.
typo, btw

https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:588: v8::V8::SetFlagsFromString(predictable_flag,
sizeof(predictable_flag) - 1);
Sigh, why are they taking an int for a string length.

[Tom Sepez, 2015-06-02 22:23:54]

On 2015/06/02 22:17:05, Lei Zhang wrote:
> lgtm

I think I'm going to go with static_cast<int>(), since sizeof returns
a size_t as well (sigh).

> https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc
> File samples/pdfium_test.cc (right):
> 
>
https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc#newc...
> samples/pdfium_test.cc:586: // By enabling predicatble mode, V8 won't post any
> background tasks.
> typo, btw
Not my typo, but will fix.


> 
>
https://codereview.chromium.org/1160293003/diff/1/samples/pdfium_test.cc#newc...
> samples/pdfium_test.cc:588: v8::V8::SetFlagsFromString(predictable_flag,
> sizeof(predictable_flag) - 1);
> Sigh, why are they taking an int for a string length.

Blame says its been this way a long time, prolly want API stability.

christian.plesner.hansen	2008-07-03 15:10:15	43d26ec	[diff] [blame]	409.	void
V8::SetFlagsFromString(const char* str, int length) {

[Tom Sepez, 2015-06-02 22:28:05]

PS#2.

[Tom Sepez, 2015-06-02 22:34:05]

On 2015/06/02 22:28:05, Tom Sepez wrote:
> PS#2.
PS#2 TBR.

[Tom Sepez, 2015-06-02 22:34:25]

Committed patchset #2 (id:20001) manually as
b29338d126125d96d63817af1d80a64ea929ffae (presubmit successful).

[Lei Zhang, 2015-06-02 22:36:27]

lgtm