components/offline_pages/DEPS - Issue 1160283003: [Offline] Creates metadata store interface for offline pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/DEPS

Issue 1160283003: [Offline] Creates metadata store interface for offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offline-pages-1

Patch Set: Adding BUILD.gn updates Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/offline_page_metadata_store.h » ('j') | components/offline_pages/offline_page_metadata_store_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service",	2 "+components/keyed_service",

3 "+net",	3 "+net",

	4 "+third_party/leveldatabase",
	Dmitry Titov 2015/06/04 00:25:52 If we can avoid this, it'd be great. For example, If we can avoid this, it'd be great. For example, we might need to implement a DB layer in Java on Android to be able to serve it via Content Provider to other apps (like Stars or Icicle) with good perf even if Chrome is not loaded. If we abstract the OfflinePagesModel from data storing layer, we migh tbe able to do it simply in the future. fgorski 2015/06/05 21:28:42 Done. Show quoted text On 2015/06/04 00:25:52, Dmitry Titov wrote: > If we can avoid this, it'd be great. For example, we might need to implement a > DB layer in Java on Android to be able to serve it via Content Provider to other > apps (like Stars or Icicle) with good perf even if Chrome is not loaded. If we > abstract the OfflinePagesModel from data storing layer, we migh tbe able to do > it simply in the future. Done.
4 ]	5 ]

OLD	NEW