Source/modules/credentialmanager/CredentialManagerClient.cpp - Issue 1160283002: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation'. (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/credentialmanager/CredentialManagerClient.cpp

Issue 1160283002: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation'. (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@rename-avatar

Patch Set: WebExposed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/CredentialManagerClient.h ('k') | Source/modules/credentialmanager/CredentialsContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/credentialmanager/CredentialManagerClient.cpp

diff --git a/Source/modules/credentialmanager/CredentialManagerClient.cpp b/Source/modules/credentialmanager/CredentialManagerClient.cpp

index d2a8000a87690cbe0726a714a81ff1a20dc69413..cf1df43476ff5d98765a85fcef2217b8d291042d 100644

--- a/Source/modules/credentialmanager/CredentialManagerClient.cpp

+++ b/Source/modules/credentialmanager/CredentialManagerClient.cpp

@@ -65,10 +65,13 @@ void CredentialManagerClient::dispatchSignedIn(const WebCredential& credential,

m_client->dispatchSignedIn(credential, callbacks);

}

-void CredentialManagerClient::dispatchSignedOut(WebCredentialManagerClient::NotificationCallbacks* callbacks)

+void CredentialManagerClient::dispatchRequireUserMediation(WebCredentialManagerClient::NotificationCallbacks* callbacks)

{

if (!m_client)

return;

+ m_client->dispatchRequireUserMediation(callbacks);

+ // TODO(mkwst): Drop this once the Chromium side is updated. https://crbug.com/494880

m_client->dispatchSignedOut(callbacks);

}