Issue 1160273005: Fix push_basic.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160273005: Fix push_basic.sh (Closed)

Created:
5 years, 6 months ago by Adrian Kuegel

Modified:
5 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/remotes/origin/master

Project:
depot_tools

Visibility:
Public.

Fix push_basic.sh This CL changes the check for base URL to a query to the json endpoint. This makes the test pass on the trybot. BUG=353718 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295538

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/push-basic.sh	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Adrian Kuegel

On 2015/06/05 12:34:15, Adrian Kuegel wrote: > Marc-Antoine, can you please review this CL? Btw, ...

5 years, 6 months ago (2015-06-05 12:35:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160273005/1

5 years, 6 months ago (2015-06-05 12:38:52 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 12:40:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295538