Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

Issue 1160273004: [CSS Grid Layout] Support dots sequences in grid-template-areas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html b/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
index ab89756add5118fb62e4ad91ce0600d49d0ee4e1..2644da387e50eb85ac97e6571c1e5a36dcbdfc0b 100644
--- a/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
@@ -25,11 +25,21 @@
".";
}
+#gridWithSpanningRowsDotsTemplate {
+ grid-template-areas: "span"
+ "....";
+}
+
#gridWithDotColumn {
grid-template-areas: "header ."
"footer .";
}
+#gridWithDotsColumn {
+ grid-template-areas: "header ......"
+ "footer ......";
+}
+
svillar 2015/06/05 10:38:09 I miss more complex use cases. I know that they sh
Manuel Rego 2015/06/05 11:20:09 Yeah, I also thought about that. I'm adding some e
#gridWithHorizontalRectangle {
grid-template-areas: "a a a"
"a a a";
@@ -51,7 +61,9 @@
<div class="grid" id="gridWithTwoRowsTemplate"></div>
<div class="grid" id="gridWithSpanningColumnsTemplate"></div>
<div class="grid" id="gridWithSpanningRowsDotTemplate"></div>
+<div class="grid" id="gridWithSpanningRowsDotsTemplate"></div>
<div class="grid" id="gridWithDotColumn"></div>
+<div class="grid" id="gridWithDotsColumn"></div>
<div class="grid" id="gridWithHorizontalRectangle"></div>
<div class="grid" id="gridWithVerticalRectangle"></div>
<script>
@@ -76,9 +88,15 @@
var gridWithSpanningRowsDotTemplate = document.getElementById("gridWithSpanningRowsDotTemplate");
shouldBeEqualToString("window.getComputedStyle(gridWithSpanningRowsDotTemplate).getPropertyValue('grid-template-areas')", '"span" "."')
+ var gridWithSpanningRowsDotsTemplate = document.getElementById("gridWithSpanningRowsDotsTemplate");
+ shouldBeEqualToString("window.getComputedStyle(gridWithSpanningRowsDotsTemplate).getPropertyValue('grid-template-areas')", '"span" "."')
+
var gridWithDotColumn = document.getElementById("gridWithDotColumn");
shouldBeEqualToString("window.getComputedStyle(gridWithDotColumn).getPropertyValue('grid-template-areas')", '"header ." "footer ."')
+ var gridWithDotsColumn = document.getElementById("gridWithDotsColumn");
+ shouldBeEqualToString("window.getComputedStyle(gridWithDotsColumn).getPropertyValue('grid-template-areas')", '"header ." "footer ."')
+
svillar 2015/06/05 10:38:09 Also if you feel like, I think we could create a t
Manuel Rego 2015/06/05 11:20:09 Good idea, but for a follow-up patch. :-)
var gridWithHorizontalRectangle = document.getElementById("gridWithHorizontalRectangle");
shouldBeEqualToString("window.getComputedStyle(gridWithHorizontalRectangle).getPropertyValue('grid-template-areas')", '"a a a" "a a a"');

Powered by Google App Engine
This is Rietveld 408576698