Issue 1160273004: [CSS Grid Layout] Support dots sequences in grid-template-areas

Issue 1160273004: [CSS Grid Layout] Support dots sequences in grid-template-areas (Closed)

Created:
4 years, 11 months ago by Manuel Rego

Modified:
4 years, 11 months ago

Reviewers:
dsinclair, Timothy Loh, Julien - ping for review, svillar

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, jfernandez, rwlbuis, svillar

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[CSS Grid Layout] Support dots sequences in grid-template-areas The CSS WG agreed to consider a sequence of "." characters a single null cell token for grid-template-areas. That way authors can match the number of dots to the width of the column. For more information see: https://lists.w3.org/Archives/Public/www-style/2015May/0175.html Added new test cases to check the new behavior. BUG=490088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196587

Patch Set 1 #

Total comments: 8

Patch Set 2 : Applied suggested changes #

Patch Set 3 : Add one more test case mixing "." and "....." #

Patch Set 4 : Rebased patch #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -2 lines)			Patch
M	LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html	View	1 2	4 chunks	+74 lines, -1 line	0 comments	Download
M	LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 2 3	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 20 (9 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

svillar

lgtm. https://codereview.chromium.org/1160273004/diff/1/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html File LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html (right): https://codereview.chromium.org/1160273004/diff/1/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html#newcode1 LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> Let's use this ...

4 years, 11 months ago (2015-06-05 10:38:09 UTC) #4

Manuel Rego

Thanks for the quick review! https://codereview.chromium.org/1160273004/diff/1/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html File LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html (right): https://codereview.chromium.org/1160273004/diff/1/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html#newcode1 LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD ...

4 years, 11 months ago (2015-06-05 11:20:10 UTC) #5