Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1160273003: Fix and re-enable URLRequestFTP tests (Except on Android). (Closed)

Created:
5 years, 6 months ago by mmenke
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable URLRequestFTP tests (Except on Android). The tests were disabled because of two failures: * The test server was failing to start. There were some CLs to fix this landed quite a while back, and the fact that URLRequestTestFTP.UnfsafePort, which (needlessly) started the FTP server was still passing indicates that this isn't a problem any longer. * Tests were having trouble accessing some test files. This CL modifies the test to use a file in the url_request_unittest directory, like the other URLRequestTest subclasses, which should hopefully fix this. Additionally, FTP is no longer enabled in the TestURLRequestContext by default, so this CL also sets up FTP support in the URLRequestTestFTP test fixture. BUG=25045, 495220 Committed: https://crrev.com/9f2ec60cde8ba05ee891bccc84fa1a05bb8d9030 Cr-Commit-Position: refs/heads/master@{#332266}

Patch Set 1 #

Patch Set 2 : Fix for DISABLE_FTP_SUPPORT #

Patch Set 3 : Disable tests on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -174 lines) Patch
M net/url_request/url_request_unittest.cc View 1 2 31 chunks +116 lines, -174 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Minus one fixit bug, plus one more. The law of conservation of bugs. :(
5 years, 6 months ago (2015-06-01 20:33:20 UTC) #2
eroman
lgtm
5 years, 6 months ago (2015-06-01 20:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160273003/40001
5 years, 6 months ago (2015-06-01 20:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-01 20:59:55 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 21:00:47 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f2ec60cde8ba05ee891bccc84fa1a05bb8d9030
Cr-Commit-Position: refs/heads/master@{#332266}

Powered by Google App Engine
This is Rietveld 408576698