Chromium Code Reviews
DescriptionFix and re-enable URLRequestFTP tests (Except on Android).
The tests were disabled because of two failures:
* The test server was failing to start. There were some CLs to fix this
landed quite a while back, and the fact that
URLRequestTestFTP.UnfsafePort, which (needlessly) started the FTP server
was still passing indicates that this isn't a problem any longer.
* Tests were having trouble accessing some test files. This CL modifies
the test to use a file in the url_request_unittest directory, like the
other URLRequestTest subclasses, which should hopefully fix this.
Additionally, FTP is no longer enabled in the TestURLRequestContext by
default, so this CL also sets up FTP support in the URLRequestTestFTP
test fixture.
BUG=25045, 495220
Committed: https://crrev.com/9f2ec60cde8ba05ee891bccc84fa1a05bb8d9030
Cr-Commit-Position: refs/heads/master@{#332266}
Patch Set 1 #Patch Set 2 : Fix for DISABLE_FTP_SUPPORT #Patch Set 3 : Disable tests on Android #Messages
Total messages: 7 (2 generated)
|