Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1160263002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in device/blu… (Closed)

Created:
5 years, 6 months ago by shail.s
Modified:
5 years, 6 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in device/bluetooth BUG=457697 R=rpaquay@chromium.org Committed: https://crrev.com/c5542fb47f81e40128d66f2c810240367c8cc1d5 Cr-Commit-Position: refs/heads/master@{#332546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
shail.s
5 years, 6 months ago (2015-06-01 09:29:01 UTC) #1
shail.s
On 2015/06/01 09:29:01, shail.s wrote: Hello Mr rpaquay, I have uploaded patch against BUG 457697. ...
5 years, 6 months ago (2015-06-02 05:30:52 UTC) #2
rpaquay
lgtm
5 years, 6 months ago (2015-06-02 15:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160263002/1
5 years, 6 months ago (2015-06-03 02:55:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 03:47:54 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 03:48:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5542fb47f81e40128d66f2c810240367c8cc1d5
Cr-Commit-Position: refs/heads/master@{#332546}

Powered by Google App Engine
This is Rietveld 408576698