Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1160253011: gn: Don't build sse3 code in skia with -msse4.1. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Don't build sse3 code in skia with -msse4.1. Else the compiler can create SSE4.1 instructions for the SSE3 files, but we only check for SSE3 when running that code. So the code might crash with "unknown instruction" when running on a processor that has SSE3 but not SSE4. This matches what the gyp build does. Depends on https://codereview.chromium.org/1161853008/ BUG=496512 Committed: https://crrev.com/8e8785dd45bee98a19ce01dd8ea3a4fc64a2e236 Cr-Commit-Position: refs/heads/master@{#333171}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M skia/BUILD.gn View 1 2 chunks +43 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
This is a bit ugly, but together with the other two CLs it's still a ...
5 years, 6 months ago (2015-06-05 19:14:00 UTC) #2
brettw
lgtm
5 years, 6 months ago (2015-06-05 20:18:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160253011/20001
5 years, 6 months ago (2015-06-05 22:27:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 23:07:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160253011/20001
5 years, 6 months ago (2015-06-05 23:10:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 23:16:18 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:17:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e8785dd45bee98a19ce01dd8ea3a4fc64a2e236
Cr-Commit-Position: refs/heads/master@{#333171}

Powered by Google App Engine
This is Rietveld 408576698