Issue 1160253010: Add CHECKs to verify that we never finalize stale copies of external strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160253010: Add CHECKs to verify that we never finalize stale copies of external strings (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add CHECKs to verify that we never finalize stale copies of external strings BUG=none R=ulan@chromium.org LOG=n Committed: https://crrev.com/ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f Cr-Commit-Position: refs/heads/master@{#28811}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/heap/mark-compact.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160253010/1

5 years, 6 months ago (2015-06-05 11:58:58 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f Cr-Commit-Position: refs/heads/master@{#28811}

5 years, 6 months ago (2015-06-05 12:10:04 UTC) #6

jochen (gone - plz use gerrit)

5 years, 6 months ago (2015-06-11 09:37:11 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1178703008/ by jochen@chromium.org.

The reason for reverting is: not needed anymore.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages