BackgroundSync sync events need to be ExtendableEvents, content browser tests

BackgroundSync sync events need to be ExtendableEvents, content browser tests

This is part of a series of patches to correctly fire the Sync event as
an ExtendableEvent, instead of a regular Event

[1/4] https://codereview.chromium.org/1162243003/, content side fix
[2/4] https://codereview.chromium.org/1148293011/, blink side fix
[3/4] This patch, content browser tests
[4/4] https://codereview.chromium.org/1146063005/, cleanup

Specific changes in this patch
- Add content browser tests for sync event
- Verify the event is created/fired with the correct type/interface
- Verify that waitUntil promise is handled correctly, both for resolve and reject

BUG=486890
Committed: https://crrev.com/09bca2984b59b0f9a5a8c0fa2f83783b4aef130b
Cr-Commit-Position: refs/heads/master@{#334858}

[chasej, 2015-06-04 16:45:17]

chasej@chromium.org changed reviewers:
+ jkarlin@chromium.org

[chasej, 2015-06-04 16:51:13]

Please take a look at the tests.  The tests won't pass until the previous CL
lands (review 1148293011), hence the try failures.  However, I think an initial
review now would be valuable.

[chasej, 2015-06-11 16:31:03]

jkarlin, PTAL.

[jkarlin, 2015-06-12 13:11:19]

lgtm with nits. Great to have these tests. You'll need to find an OWNER of
course.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1187: // The js
event handler will console.log the event properties
Missing periods after each sentence.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1191:
EXPECT_FALSE(console_output.empty()) << "Console output should not be empty";
The string seems redundant here.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1212: // the js
event handler will console.log the expected output
missing period at end of sentence

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1224: // the js
event handler will console.log the expected output
ditto

https://codereview.chromium.org/1160253004/diff/1/content/test/data/backgroun...
File content/test/data/background_sync/sync_event_fulfilled.js (right):

https://codereview.chromium.org/1160253004/diff/1/content/test/data/backgroun...
content/test/data/background_sync/sync_event_fulfilled.js:1: // Copyright 2014
The Chromium Authors. All rights reserved.
2015 here and all other files

[chasej, 2015-06-12 14:08:17]

Patchset #2 (id:20001) has been deleted

[chasej, 2015-06-12 14:21:50]

Patchset #2 (id:40001) has been deleted

[chasej, 2015-06-12 15:30:25]

Patchset #2 (id:60001) has been deleted

[chasej, 2015-06-12 15:33:10]

Patchset #2 (id:80001) has been deleted

[chasej, 2015-06-12 16:04:13]

Addressed the nits.  Unfortunately, had to rebase first.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1187: // The js
event handler will console.log the event properties
On 2015/06/12 13:11:18, jkarlin wrote:
> Missing periods after each sentence.

Done.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1191:
EXPECT_FALSE(console_output.empty()) << "Console output should not be empty";
On 2015/06/12 13:11:18, jkarlin wrote:
> The string seems redundant here.

Done.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1212: // the js
event handler will console.log the expected output
On 2015/06/12 13:11:18, jkarlin wrote:
> missing period at end of sentence

Done.

https://codereview.chromium.org/1160253004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:1224: // the js
event handler will console.log the expected output
On 2015/06/12 13:11:18, jkarlin wrote:
> ditto

Done.

https://codereview.chromium.org/1160253004/diff/1/content/test/data/backgroun...
File content/test/data/background_sync/sync_event_fulfilled.js (right):

https://codereview.chromium.org/1160253004/diff/1/content/test/data/backgroun...
content/test/data/background_sync/sync_event_fulfilled.js:1: // Copyright 2014
The Chromium Authors. All rights reserved.
On 2015/06/12 13:11:18, jkarlin wrote:
> 2015 here and all other files

Done.

[chasej, 2015-06-12 16:06:52]

chasej@chromium.org changed reviewers:
+ michaeln@chromium.org

[chasej, 2015-06-12 16:07:41]

michaeln, please take a look (as you reviewed the previous related CLs).

[michaeln, 2015-06-15 20:34:32]

lgtm 2

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
File content/test/data/background_sync/sync_event_fulfilled.js (right):

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
content/test/data/background_sync/sync_event_fulfilled.js:13:
resolve("Fulfilled");
I don't think the "Fulfilled" value being passed to resolve is used, if not, i'd
suggest removing it to avoid confusion.

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
File content/test/data/background_sync/sync_event_rejected.js (right):

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
content/test/data/background_sync/sync_event_rejected.js:13: reject("Rejected");
ditto "Rejected" value not used (i think)

[chasej, 2015-06-17 16:18:07]

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
File content/test/data/background_sync/sync_event_fulfilled.js (right):

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
content/test/data/background_sync/sync_event_fulfilled.js:13:
resolve("Fulfilled");
On 2015/06/15 20:34:32, michaeln wrote:
> I don't think the "Fulfilled" value being passed to resolve is used, if not,
i'd
> suggest removing it to avoid confusion.

Done.

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
File content/test/data/background_sync/sync_event_rejected.js (right):

https://codereview.chromium.org/1160253004/diff/120001/content/test/data/back...
content/test/data/background_sync/sync_event_rejected.js:13: reject("Rejected");
On 2015/06/15 20:34:32, michaeln wrote:
> ditto "Rejected" value not used (i think)

Done.

[chasej, 2015-06-17 16:18:24]

The CQ bit was checked by chasej@chromium.org

[chasej, 2015-06-17 16:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/1160253004/#ps140001
(title: "Address comments")

[commit-bot: I haz the power, 2015-06-17 16:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160253004/140001

[commit-bot: I haz the power, 2015-06-17 16:55:00]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-06-17 16:57:12]

Patchset 4 (id:??) landed as
https://crrev.com/09bca2984b59b0f9a5a8c0fa2f83783b4aef130b
Cr-Commit-Position: refs/heads/master@{#334858}