Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: sky/sdk/lib/framework/rendering/box.dart

Issue 1160233004: Improve the RenderObject.toString() logic so that there's not blank lines everywhere and to general… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fix matrix output, comment out debug line Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/fn2.dart ('k') | sky/sdk/lib/framework/rendering/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/box.dart
diff --git a/sky/sdk/lib/framework/rendering/box.dart b/sky/sdk/lib/framework/rendering/box.dart
index 04be3199e43de13f4c4204e012e3fc42e483e071..cd02fdb41e1500763a0baa6d8e477623d84501b0 100644
--- a/sky/sdk/lib/framework/rendering/box.dart
+++ b/sky/sdk/lib/framework/rendering/box.dart
@@ -150,6 +150,8 @@ abstract class RenderBox extends RenderObject {
void hitTestChildren(HitTestResult result, { sky.Point position }) { }
sky.Size size = new sky.Size(0.0, 0.0);
+
+ String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}size: ${size}\n';
}
abstract class RenderProxyBox extends RenderBox with RenderObjectWithChildMixin<RenderBox> {
@@ -215,7 +217,7 @@ class RenderSizedBox extends RenderProxyBox {
child.layout(new BoxConstraints.tight(size));
}
- String debugDescribeSettings(String prefix) => '${prefix}desiredSize: ${desiredSize}';
+ String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}desiredSize: ${desiredSize}\n';
}
class RenderClip extends RenderProxyBox {
@@ -288,7 +290,7 @@ class RenderPadding extends RenderBox with RenderObjectWithChildMixin<RenderBox>
}
}
- String debugDescribeSettings(String prefix) => '${prefix}padding: ${padding}';
+ String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}padding: ${padding}\n';
}
class RenderImage extends RenderBox {
@@ -364,7 +366,7 @@ class RenderImage extends RenderBox {
canvas.restore();
}
- String debugDescribeSettings(String prefix) => '${prefix}url: ${src}\n${prefix}dimensions: ${requestedSize}';
+ String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}url: ${src}\n${prefix}dimensions: ${requestedSize}\n';
}
class BorderSide {
@@ -513,7 +515,7 @@ class RenderDecoratedBox extends RenderProxyBox {
super.paint(canvas);
}
- String debugDescribeSettings(String prefix) => '${prefix}decoration:\n${decoration.toString(prefix + " ")}';
+ String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}decoration:\n${decoration.toString(prefix + " ")}\n';
}
class RenderTransform extends RenderProxyBox {
@@ -577,6 +579,12 @@ class RenderTransform extends RenderProxyBox {
super.paint(canvas);
canvas.restore();
}
+
+ String debugDescribeSettings(String prefix) {
+ List<String> result = _transform.toString().split('\n').map((s) => '$prefix $s\n').toList();
+ result.removeLast();
+ return '${super.debugDescribeSettings(prefix)}${prefix}transform matrix:\n${result.join()}';
+ }
}
typedef void SizeChangedCallback(sky.Size newSize);
« no previous file with comments | « sky/sdk/lib/framework/fn2.dart ('k') | sky/sdk/lib/framework/rendering/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698