lib/src/codegen/side_effect_analysis.dart - Issue 1160223006: Fix DDC errors on DDC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/side_effect_analysis.dart

Issue 1160223006: Fix DDC errors on DDC (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: address comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/side_effect_analysis.dart

diff --git a/lib/src/codegen/side_effect_analysis.dart b/lib/src/codegen/side_effect_analysis.dart

index 6ae46d83f4fcf0edd531288ecfa359321036ccfa..df355d8bc4ed6559f7cd047907428b05286dbba3 100644

--- a/lib/src/codegen/side_effect_analysis.dart

+++ b/lib/src/codegen/side_effect_analysis.dart

@@ -36,7 +36,8 @@ bool isStateless(Expression node, [AstNode context]) {

if (node is ThisExpression || node is SuperExpression) return true;

if (node is SimpleIdentifier) {

var e = node.staticElement;

- if (e is PropertyAccessorElement) e = e.variable;

+ if (e is PropertyAccessorElement) e =

+ (e as PropertyAccessorElement).variable;

if (e is VariableElement && !e.isSynthetic) {

if (e.isFinal) return true;

if (e is LocalVariableElement || e is ParameterElement) {

« no previous file with comments | « lib/src/codegen/reify_coercions.dart ('k') | lib/src/dependency_graph.dart » ('j') | no next file with comments »