Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: lib/src/checker/checker.dart

Issue 1160223006: Fix DDC errors on DDC (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/checker/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/checker.dart
diff --git a/lib/src/checker/checker.dart b/lib/src/checker/checker.dart
index b114ba08c4402fcf1fe0d4b47aeec86e72bf7afb..3bd7c88f414eea7d01c504007e755a4f0b4ddfa8 100644
--- a/lib/src/checker/checker.dart
+++ b/lib/src/checker/checker.dart
@@ -227,10 +227,11 @@ class _OverrideChecker {
if (member is FieldDeclaration) {
if (member.isStatic) continue;
for (var variable in member.fields.variables) {
- var name = variable.element.name;
+ var element = variable.element as PropertyInducingElement;
+ var name = element.name;
if (seen.contains(name)) continue;
- var getter = variable.element.getter;
- var setter = variable.element.setter;
+ var getter = element.getter;
+ var setter = element.setter;
bool found = _checkSingleOverride(getter, baseType, variable, member);
if (!variable.isFinal &&
_checkSingleOverride(setter, baseType, variable, member)) {
@@ -239,8 +240,7 @@ class _OverrideChecker {
if (found) seen.add(name);
}
} else {
- assert(member is MethodDeclaration);
- if (member.isStatic) continue;
+ if ((member as MethodDeclaration).isStatic) continue;
var method = member.element;
if (seen.contains(method.name)) continue;
if (_checkSingleOverride(method, baseType, member, member)) {
« no previous file with comments | « no previous file | lib/src/checker/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698