Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: Source/platform/graphics/paint/DrawingRecorder.cpp

Issue 1160223004: Avoid false-positives of under-invalidation checking (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix build break (release w/ assert) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/paint/DrawingRecorder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DrawingRecorder.cpp
diff --git a/Source/platform/graphics/paint/DrawingRecorder.cpp b/Source/platform/graphics/paint/DrawingRecorder.cpp
index 65d0aeaeee5d53cdcff8e0a260558a6d207d4643..7395b4e971e71726c817aee7b481945d5fcd16bc 100644
--- a/Source/platform/graphics/paint/DrawingRecorder.cpp
+++ b/Source/platform/graphics/paint/DrawingRecorder.cpp
@@ -10,7 +10,6 @@
#include "platform/graphics/GraphicsLayer.h"
#include "platform/graphics/paint/CachedDisplayItem.h"
#include "platform/graphics/paint/DisplayItemList.h"
-#include "platform/graphics/paint/DrawingDisplayItem.h"
#include "third_party/skia/include/core/SkPicture.h"
namespace blink {
@@ -23,7 +22,7 @@ DrawingRecorder::DrawingRecorder(GraphicsContext& context, const DisplayItemClie
#if ENABLE(ASSERT)
, m_checkedCachedDrawing(false)
, m_displayItemPosition(RuntimeEnabledFeatures::slimmingPaintEnabled() ? m_context.displayItemList()->newDisplayItemsSize() : 0)
- , m_skipUnderInvalidationChecking(false)
+ , m_underInvalidationCheckingMode(DrawingDisplayItem::CheckPicture)
#endif
{
if (!RuntimeEnabledFeatures::slimmingPaintEnabled())
@@ -90,8 +89,7 @@ DrawingRecorder::~DrawingRecorder()
} else {
OwnPtr<DrawingDisplayItem> drawingDisplayItem = DrawingDisplayItem::create(m_displayItemClient, m_displayItemType, m_context.endRecording());
#if ENABLE(ASSERT)
- if (m_skipUnderInvalidationChecking)
- drawingDisplayItem->setSkipUnderInvalidationChecking();
+ drawingDisplayItem->setUnderInvalidationCheckingMode(m_underInvalidationCheckingMode);
#endif
m_context.displayItemList()->add(drawingDisplayItem.release());
}
« no previous file with comments | « Source/platform/graphics/paint/DrawingRecorder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698