Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1160203003: net: Remove the remaining use of GG_(U)INTn_C macros. (Closed)

Created:
5 years, 6 months ago by tfarina
Modified:
5 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, viettrungluu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove the remaining use of GG_(U)INTn_C macros. According to comment in base/port.h, in Chromium, we force-define __STDC_CONSTANT_MACROS, so we can just use the regular (U)INTn_C macros from <stdint.h>. BUG=138542 TEST=net_unittests R=mattm@chromium.org Committed: https://crrev.com/3723da2ffa46c2d92d7694b12f6a266f80c9dfa2 Cr-Commit-Position: refs/heads/master@{#332695}

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 2

Patch Set 3 : stdint.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -269 lines) Patch
M net/base/network_activity_monitor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M net/disk_cache/blockfile/sparse_control.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_entry_format.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_entry_format_history.h View 1 chunk +4 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_util_unittest.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M net/disk_cache/simple/simple_version_upgrade_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/http/http_security_headers_unittest.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/cubic_bytes.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/crypto/common_cert_set_1.c View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/common_cert_set_test.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/crypto/null_decrypter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_bandwidth.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_data_writer.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_data_writer_test.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 6 chunks +12 lines, -10 lines 0 comments Download
M net/quic/quic_framer_test.cc View 71 chunks +131 lines, -148 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_time.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/test/ct_test_util.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/websockets/websocket_basic_stream_test.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M net/websockets/websocket_frame_parser_test.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M net/websockets/websocket_frame_test.cc View 4 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
tfarina
5 years, 6 months ago (2015-05-31 01:36:26 UTC) #1
mattm
lgtm
5 years, 6 months ago (2015-06-01 22:42:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160203003/1
5 years, 6 months ago (2015-06-02 00:27:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/81320) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-02 00:46:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160203003/20001
5 years, 6 months ago (2015-06-03 19:53:59 UTC) #9
mattm
https://codereview.chromium.org/1160203003/diff/20001/net/extras/sqlite/sqlite_channel_id_store_unittest.cc File net/extras/sqlite/sqlite_channel_id_store_unittest.cc (right): https://codereview.chromium.org/1160203003/diff/20001/net/extras/sqlite/sqlite_channel_id_store_unittest.cc#newcode5 net/extras/sqlite/sqlite_channel_id_store_unittest.cc:5: #include <stdint.h> This one is no longer necessary?
5 years, 6 months ago (2015-06-03 19:55:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160203003/40001
5 years, 6 months ago (2015-06-03 20:28:37 UTC) #14
tfarina
https://codereview.chromium.org/1160203003/diff/20001/net/extras/sqlite/sqlite_channel_id_store_unittest.cc File net/extras/sqlite/sqlite_channel_id_store_unittest.cc (right): https://codereview.chromium.org/1160203003/diff/20001/net/extras/sqlite/sqlite_channel_id_store_unittest.cc#newcode5 net/extras/sqlite/sqlite_channel_id_store_unittest.cc:5: #include <stdint.h> On 2015/06/03 19:55:11, mattm wrote: > This ...
5 years, 6 months ago (2015-06-03 20:28:39 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 21:39:38 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 21:41:39 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3723da2ffa46c2d92d7694b12f6a266f80c9dfa2
Cr-Commit-Position: refs/heads/master@{#332695}

Powered by Google App Engine
This is Rietveld 408576698