Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: mojo/edk/system/data_pipe_impl_unittest.cc

Issue 1160203002: Make Dispatcher::Type an enum class. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/data_pipe_impl_unittest.cc
diff --git a/mojo/edk/system/data_pipe_impl_unittest.cc b/mojo/edk/system/data_pipe_impl_unittest.cc
index 3a774881bb4ce14a2f5fd1d4e03950d68b02b86e..1688e3d288acdc5cf98cf8751f3a800d827e172f 100644
--- a/mojo/edk/system/data_pipe_impl_unittest.cc
+++ b/mojo/edk/system/data_pipe_impl_unittest.cc
@@ -376,7 +376,7 @@ class RemoteProducerDataPipeImplTestHelper
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeProducer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_PRODUCER, to_receive->GetType());
producer_dispatcher_ =
static_cast<DataPipeProducerDispatcher*>(to_receive.get());
}
@@ -426,7 +426,7 @@ class RemoteConsumerDataPipeImplTestHelper
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeConsumer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER, to_receive->GetType());
consumer_dispatcher_ =
static_cast<DataPipeConsumerDispatcher*>(to_receive.get());
}
@@ -480,7 +480,7 @@ class RemoteProducerDataPipeImplTestHelper2
// destroyed.
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeProducer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_PRODUCER, to_receive->GetType());
to_send = static_cast<DataPipeProducerDispatcher*>(to_receive.get());
to_receive = nullptr;
@@ -491,7 +491,7 @@ class RemoteProducerDataPipeImplTestHelper2
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeProducer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_PRODUCER, to_receive->GetType());
producer_dispatcher_ =
static_cast<DataPipeProducerDispatcher*>(to_receive.get());
}
@@ -527,7 +527,7 @@ class RemoteConsumerDataPipeImplTestHelper2
// destroyed.
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeConsumer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER, to_receive->GetType());
to_send = static_cast<DataPipeConsumerDispatcher*>(to_receive.get());
to_receive = nullptr;
@@ -538,7 +538,7 @@ class RemoteConsumerDataPipeImplTestHelper2
EXPECT_TRUE(to_send->HasOneRef());
to_send = nullptr;
- ASSERT_EQ(Dispatcher::kTypeDataPipeConsumer, to_receive->GetType());
+ ASSERT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER, to_receive->GetType());
consumer_dispatcher_ =
static_cast<DataPipeConsumerDispatcher*>(to_receive.get());
}

Powered by Google App Engine
This is Rietveld 408576698