Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: mojo/edk/system/dispatcher_unittest.cc

Issue 1160203002: Make Dispatcher::Type an enum class. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/system/dispatcher.h" 5 #include "mojo/edk/system/dispatcher.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
11 #include "base/threading/simple_thread.h" 11 #include "base/threading/simple_thread.h"
12 #include "mojo/edk/embedder/platform_shared_buffer.h" 12 #include "mojo/edk/embedder/platform_shared_buffer.h"
13 #include "mojo/edk/system/memory.h" 13 #include "mojo/edk/system/memory.h"
14 #include "mojo/edk/system/waiter.h" 14 #include "mojo/edk/system/waiter.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 16
17 namespace mojo { 17 namespace mojo {
18 namespace system { 18 namespace system {
19 namespace { 19 namespace {
20 20
21 // Trivial subclass that makes the constructor public. 21 // Trivial subclass that makes the constructor public.
22 class TrivialDispatcher : public Dispatcher { 22 class TrivialDispatcher : public Dispatcher {
23 public: 23 public:
24 TrivialDispatcher() {} 24 TrivialDispatcher() {}
25 25
26 Type GetType() const override { return kTypeUnknown; } 26 Type GetType() const override { return Type::UNKNOWN; }
27 27
28 private: 28 private:
29 friend class base::RefCountedThreadSafe<TrivialDispatcher>; 29 friend class base::RefCountedThreadSafe<TrivialDispatcher>;
30 ~TrivialDispatcher() override {} 30 ~TrivialDispatcher() override {}
31 31
32 scoped_refptr<Dispatcher> CreateEquivalentDispatcherAndCloseImplNoLock() 32 scoped_refptr<Dispatcher> CreateEquivalentDispatcherAndCloseImplNoLock()
33 override { 33 override {
34 lock().AssertAcquired(); 34 lock().AssertAcquired();
35 return scoped_refptr<Dispatcher>(new TrivialDispatcher()); 35 return scoped_refptr<Dispatcher>(new TrivialDispatcher());
36 } 36 }
37 37
38 DISALLOW_COPY_AND_ASSIGN(TrivialDispatcher); 38 DISALLOW_COPY_AND_ASSIGN(TrivialDispatcher);
39 }; 39 };
40 40
41 TEST(DispatcherTest, Basic) { 41 TEST(DispatcherTest, Basic) {
42 scoped_refptr<Dispatcher> d(new TrivialDispatcher()); 42 scoped_refptr<Dispatcher> d(new TrivialDispatcher());
43 43
44 EXPECT_EQ(Dispatcher::kTypeUnknown, d->GetType()); 44 EXPECT_EQ(Dispatcher::Type::UNKNOWN, d->GetType());
45 45
46 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 46 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
47 d->WriteMessage(NullUserPointer(), 0, nullptr, 47 d->WriteMessage(NullUserPointer(), 0, nullptr,
48 MOJO_WRITE_MESSAGE_FLAG_NONE)); 48 MOJO_WRITE_MESSAGE_FLAG_NONE));
49 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 49 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
50 d->ReadMessage(NullUserPointer(), NullUserPointer(), nullptr, 50 d->ReadMessage(NullUserPointer(), NullUserPointer(), nullptr,
51 nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE)); 51 nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));
52 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 52 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
53 d->WriteData(NullUserPointer(), NullUserPointer(), 53 d->WriteData(NullUserPointer(), NullUserPointer(),
54 MOJO_WRITE_DATA_FLAG_NONE)); 54 MOJO_WRITE_DATA_FLAG_NONE));
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 event.Signal(); 298 event.Signal();
299 } // Joins all the threads. 299 } // Joins all the threads.
300 300
301 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 301 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
302 } 302 }
303 } 303 }
304 304
305 } // namespace 305 } // namespace
306 } // namespace system 306 } // namespace system
307 } // namespace mojo 307 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698