Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 11602010: Initial commit of the ONC spec in HTML. (Closed)

Created:
8 years ago by pneubeck (no reviews)
Modified:
8 years ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Initial commit of the ONC spec in HTML. BUG=166413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173970

Patch Set 1 : Initial patch. #

Patch Set 2 : Moved to chromeos/docs. #

Total comments: 1

Patch Set 3 : Added Greg to OWNERS. #

Patch Set 4 : Added license headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2123 lines, -0 lines) Patch
A chromeos/docs/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chromeos/docs/onc_spec.css View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A chromeos/docs/onc_spec.html View 1 1 chunk +2020 lines, -0 lines 0 comments Download
A chromeos/docs/onc_spec.js View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pneubeck (no reviews)
Hi, according to b/7620483, I have created an initial HTML version of the ONC spec. ...
8 years ago (2012-12-17 15:36:10 UTC) #1
stevenjb
In chrome we have src/chrome/common/extensions/docs, but I think I would prefer: src/chromeos/docs/onc/ for this. Greg, ...
8 years ago (2012-12-18 00:43:42 UTC) #2
pneubeck (no reviews)
Moved to chromeos/docs as Steven suggested.
8 years ago (2012-12-18 16:35:01 UTC) #3
stevenjb
lgtm
8 years ago (2012-12-18 18:20:14 UTC) #4
Greg Spencer (Chromium)
LGTM https://codereview.chromium.org/11602010/diff/7001/chromeos/docs/OWNERS File chromeos/docs/OWNERS (right): https://codereview.chromium.org/11602010/diff/7001/chromeos/docs/OWNERS#newcode1 chromeos/docs/OWNERS:1: pneubeck@chromium.org Can you add me to the OWNERS ...
8 years ago (2012-12-19 17:16:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11602010/10002
8 years ago (2012-12-19 17:21:37 UTC) #6
commit-bot: I haz the power
Presubmit check for 11602010-10002 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-19 17:21:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11602010/10003
8 years ago (2012-12-19 17:29:03 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-19 19:22:20 UTC) #9
Message was sent while issue was closed.
Change committed as 173970

Powered by Google App Engine
This is Rietveld 408576698