Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1160183003: Use SkPictureBuilder in SVGShapePainter, and generalize SkPictureBuilder. (Closed)

Created:
4 years, 11 months ago by chrishtr
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use SkPictureBuilder in SVGShapePainter. Generalize SkPictureBuilder to allow passing a contextual GraphicsContext, from which various global state bits are taken. Update existing call sites that were previously potentially broken to this. BUG=486830 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197133

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -86 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceClipper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/paint/SVGClipPainter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGMaskPainter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGShapePainter.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 1 2 3 4 5 5 chunks +22 lines, -20 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GeneratedImage.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D Source/platform/graphics/paint/DisplayItemListContextRecorder.h View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
M Source/platform/graphics/paint/SkPictureBuilder.h View 1 2 3 4 5 2 chunks +10 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chrishtr
4 years, 11 months ago (2015-06-02 21:36:43 UTC) #2
pdr.
https://codereview.chromium.org/1160183003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1160183003/diff/20001/LayoutTests/TestExpectations#newcode22 LayoutTests/TestExpectations:22: #crbug.com/453972 [ Linux ] virtual/slimmingpaint/svg [ Skip ] hashtag ...
4 years, 11 months ago (2015-06-02 21:47:52 UTC) #3
chrishtr
Updated CL.
4 years, 10 months ago (2015-06-14 05:39:18 UTC) #4
pdr.
LGTM
4 years, 10 months ago (2015-06-15 00:02:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160183003/100001
4 years, 10 months ago (2015-06-15 15:33:01 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 18:51:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197133

Powered by Google App Engine
This is Rietveld 408576698