Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1160143008: Revert "MIPS64: Fix lithium arithmetic operations for integers to sign-extend result." (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "MIPS64: Fix lithium arithmetic operations for integers to sign-extend result." This reverts commit 75744da2689c57c3c8c5bbff2965fe9afe602258. revert reason: octane failures. BUG= Committed: https://crrev.com/ca0991c9bc665ce05d553733117339664832ce34 Cr-Commit-Position: refs/heads/master@{#28819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/mips64/lithium-codegen-mips64.cc View 5 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dusmil.imgtec
5 years, 6 months ago (2015-06-05 17:46:29 UTC) #2
akos.palfi.imgtec
LGTM
5 years, 6 months ago (2015-06-05 17:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160143008/1
5 years, 6 months ago (2015-06-05 17:49:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 18:22:19 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:34:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca0991c9bc665ce05d553733117339664832ce34
Cr-Commit-Position: refs/heads/master@{#28819}

Powered by Google App Engine
This is Rietveld 408576698