Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1160143004: Introduce a flag to overwrite Date.now() with a fixed value (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a flag to overwrite Date.now() with a fixed value BUG=none R=jkummerow@chromium.org LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/fixed-date.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-02 12:29:33 UTC) #1
jochen (gone - plz use gerrit)
wdyt?
5 years, 6 months ago (2015-06-02 12:30:49 UTC) #2
Jakob Kummerow
I'm kind of questioning the need for this, but... whatever. LGTM.
5 years, 6 months ago (2015-06-02 12:33:19 UTC) #3
Toon Verwaest
Mmh, why not just monkey patch by loading a script? If you can pass a ...
5 years, 6 months ago (2015-06-03 09:37:25 UTC) #5
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-03 10:28:13 UTC) #6
yeah, closing this cl

Powered by Google App Engine
This is Rietveld 408576698