Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 1160113004: HTML exit reader view button (Closed)

Created:
5 years, 6 months ago by mdjones
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTML exit reader view button This change removes the 'view original' link and replaces it with a button that currently navigates to the original article but will eventually slide the view out of focus. The feedback form and close button now span the full width of a page while content is limited to 800px wide. BUG=428533 Committed: https://crrev.com/ae0286c350696ba16a8119af2af4aee2f06859e9 Cr-Commit-Position: refs/heads/master@{#333759}

Patch Set 1 #

Patch Set 2 : Fix iOS #

Patch Set 3 : Exclude distiller css in presubmit #

Patch Set 4 : Fix test #

Patch Set 5 : Separate iOS CSS file #

Patch Set 6 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -77 lines) Patch
M PRESUBMIT.py View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M build/ios/grit_whitelist.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M components/dom_distiller/core/css/distilledpage.css View 1 2 3 4 5 3 chunks +22 lines, -11 lines 0 comments Download
A components/dom_distiller/core/css/distilledpage_ios.css View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M components/dom_distiller/core/html/dom_distiller_viewer.html View 1 chunk +48 lines, -50 lines 0 comments Download
M components/dom_distiller/core/javascript/dom_distiller_viewer.js View 1 2 3 4 3 chunks +15 lines, -6 lines 0 comments Download
M components/dom_distiller/core/viewer.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M components/dom_distiller_strings.grdp View 2 chunks +3 lines, -3 lines 0 comments Download
M components/resources/dom_distiller_resources.grdp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/test/data/dom_distiller/pinch_tester.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
mdjones
5 years, 6 months ago (2015-06-03 16:36:33 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-04 20:40:50 UTC) #3
mdjones
+noyau for ios/ +jochen for PRESUBMIT.py
5 years, 6 months ago (2015-06-04 23:01:27 UTC) #5
noyau (Ping after 24h)
ios/ lgtm.
5 years, 6 months ago (2015-06-05 07:21:30 UTC) #6
jochen (gone - plz use gerrit)
please don't use prefixed CSS properties. This will screw up our use counters. I understand ...
5 years, 6 months ago (2015-06-05 12:19:19 UTC) #7
mdjones
On 2015/06/05 12:19:19, jochen wrote: > please don't use prefixed CSS properties. This will screw ...
5 years, 6 months ago (2015-06-09 00:10:40 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-09 08:14:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160113004/100001
5 years, 6 months ago (2015-06-10 15:51:39 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-10 18:10:45 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:11:34 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae0286c350696ba16a8119af2af4aee2f06859e9
Cr-Commit-Position: refs/heads/master@{#333759}

Powered by Google App Engine
This is Rietveld 408576698