Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1160113003: Treat 'revert' like 'update' in gclient. (Closed)

Created:
5 years, 6 months ago by agable
Modified:
5 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Treat 'revert' like 'update' in gclient. This cl ensures that gclient enforces sane revision overrides and onfiguration when running a revert, just like it does on a normal sync/update. R=iannucci@chromium.org BUG=420919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
agable
5 years, 6 months ago (2015-06-02 18:27:44 UTC) #1
agable
Ping
5 years, 6 months ago (2015-06-08 23:20:37 UTC) #2
iannucci
Erm... more context in description and/or bug? code lgtm though.
5 years, 6 months ago (2015-06-08 23:23:14 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 6 months ago (2015-06-09 00:30:04 UTC) #6
agable
5 years, 6 months ago (2015-06-09 00:45:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 295571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698