Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4863)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Harmonize MessageLoop/TTRH usage. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index da40c2163e5bc291e83db2b6df07fa15c06cc2d7..6bf3b40fa9ebdde8744016283191ac3682800dba 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -204,7 +204,7 @@ void CloseWindowCallback(Browser* browser) {
// menu.
void RunCloseWithAppMenuCallback(Browser* browser) {
// ShowAppMenu is modal under views. Schedule a task that closes the window.
- base::MessageLoop::current()->PostTask(
+ base::MessageLoop::current()->task_runner()->PostTask(
msw 2015/06/12 00:31:21 nit: include message_loop.h and base/location.h
Sami 2015/06/12 10:56:22 Done.
FROM_HERE, base::Bind(&CloseWindowCallback, browser));
chrome::ShowAppMenu(browser);
}
@@ -918,8 +918,8 @@ class BeforeUnloadAtQuitWithTwoWindows : public InProcessBrowserTest {
// Run the application event loop to completion, which will cycle the
// native MessagePump on all platforms.
- base::MessageLoop::current()->PostTask(FROM_HERE,
- base::MessageLoop::QuitClosure());
+ base::MessageLoop::current()->task_runner()->PostTask(
+ FROM_HERE, base::MessageLoop::QuitClosure());
base::MessageLoop::current()->Run();
// Take care of any remaining Cocoa work.
@@ -1591,7 +1591,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, CloseWithAppMenuOpen) {
return;
// We need a message loop running for menus on windows.
- base::MessageLoop::current()->PostTask(
+ base::MessageLoop::current()->task_runner()->PostTask(
FROM_HERE, base::Bind(&RunCloseWithAppMenuCallback, browser()));
}

Powered by Google App Engine
This is Rietveld 408576698