chrome/browser/ui/views/menu_model_adapter_test.cc - Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/menu_model_adapter_test.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for task runner instead of current message loop. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc ('K') | « chrome/browser/ui/views/importer/import_lock_dialog_view.cc ('k') | chrome/browser/ui/views/message_center/web_notification_tray.cc » ('j') | chrome/browser/ui/views/status_bubble_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/menu_model_adapter_test.cc

diff --git a/chrome/browser/ui/views/menu_model_adapter_test.cc b/chrome/browser/ui/views/menu_model_adapter_test.cc

index 3ecde40e25db3c6ebe7009e69b6a15ad28d6d92a..aedbfc5e3f8c92577cb355ee912e8d379a64c7ad 100644

--- a/chrome/browser/ui/views/menu_model_adapter_test.cc

+++ b/chrome/browser/ui/views/menu_model_adapter_test.cc

@@ -3,7 +3,10 @@

// found in the LICENSE file.

#include "base/callback.h"

+#include "base/location.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/test/base/interactive_test_utils.h"

#include "chrome/test/base/ui_test_utils.h"

#include "chrome/test/base/view_event_test_base.h"

@@ -228,7 +231,7 @@ class MenuModelAdapterTest : public ViewEventTestBase,

menu_model_adapter_.BuildMenu(menu_);

- base::MessageLoopForUI::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, CreateEventTask(this, &MenuModelAdapterTest::Step3));

}