chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc - Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/app_list_service_impl.cc ('K') | « chrome/browser/ui/sync/one_click_signin_sync_observer.cc ('k') | chrome/browser/ui/tabs/hover_tab_selector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

index 0eb025b0f9fd85abfd7265f205b1010b5ff9598e..2ce91ba3e44851cf7fcf1214da0941ec27ec4820 100644

--- a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

+++ b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

@@ -5,7 +5,10 @@

#include "chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h"

#include "base/bind.h"

+#include "base/location.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_dialogs.h"

@@ -130,8 +133,8 @@ IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Navigate) {

}

IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Quit) {

- base::MessageLoopForUI::current()->PostTask(FROM_HERE,

- base::Bind(&chrome::AttemptExit));

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::Bind(&chrome::AttemptExit));

content::RunMessageLoop();

EXPECT_EQ(0, accepted_count_);

EXPECT_EQ(0, canceled_count_);