chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

chrome/browser/ui/app_list/app_list_service_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_service_impl.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/location.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
+#include "base/single_thread_task_runner.h"
 #include "base/strings/string16.h"
+#include "base/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
 #include "chrome/browser/ui/app_list/profile_loader.h"
 #include "chrome/browser/ui/app_list/profile_store.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
@@ skipping 146 matching lines @@
   base::Time app_list_enable_time =
       base::Time::FromInternalValue(enable_time_value);
   if (is_startup_check) {
     // When checking at startup, only clear and record the "timeout" case,
     // otherwise wait for a timeout.
     base::TimeDelta time_remaining =
         app_list_enable_time +
         base::TimeDelta::FromMinutes(kDiscoverabilityTimeoutMinutes) -
         base::Time::Now();
     if (time_remaining > base::TimeDelta()) {
-      base::MessageLoop::current()->PostDelayedTask(
-          FROM_HERE,
-          base::Bind(&RecordAppListDiscoverability,
-                     base::Unretained(local_state),
-                     false),
+      base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+          FROM_HERE, base::Bind(&RecordAppListDiscoverability,
+                                base::Unretained(local_state), false),
           time_remaining);
       return;
     }
   }
 
   local_state->SetInt64(prefs::kAppListEnableTime, 0);
 
   AppListService::AppListEnableSource enable_source =
       static_cast<AppListService::AppListEnableSource>(
           local_state->GetInteger(prefs::kAppListEnableMethod));
@@ skipping 215 matching lines @@
     return;
   }
 
   local_state_->SetBoolean(prefs::kAppLauncherHasBeenEnabled, true);
   CreateShortcut();
 
   // UMA for launcher discoverability.
   local_state_->SetInt64(prefs::kAppListEnableTime,
                          base::Time::Now().ToInternalValue());
   local_state_->SetInteger(prefs::kAppListEnableMethod, enable_source);
   if (base::MessageLoop::current()) {

[msw, 2015/06/09 00:51:56]

Shouldn't this now check base::ThreadTaskRunnerHandle::IsSet() or similar?
Ditto below and the next file in the CL, please audit throughout as needed.

[Sami, 2015/06/09 10:20:08]

Well spotted, thanks. Fixed here, below and in app_list_shower_views.cc which
were the only instances.

     // Ensure a value is recorded if the user "never" shows the app list. Note
     // there is no message loop in unit tests.
-    base::MessageLoop::current()->PostDelayedTask(
-        FROM_HERE,
-        base::Bind(&RecordAppListDiscoverability,
-                   base::Unretained(local_state_),
-                   false),
+    base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+        FROM_HERE, base::Bind(&RecordAppListDiscoverability,
+                              base::Unretained(local_state_), false),
         base::TimeDelta::FromMinutes(kDiscoverabilityTimeoutMinutes));
   }
 }
 
 void AppListServiceImpl::InvalidatePendingProfileLoads() {
   profile_loader_->InvalidatePendingProfileLoads();
 }
 
 void AppListServiceImpl::PerformStartupChecks(Profile* initial_profile) {
   // Except in rare, once-off cases, this just checks that a pref is "0" and
   // returns.
   RecordAppListDiscoverability(local_state_, true);
 
   if (command_line_.HasSwitch(switches::kResetAppListInstallState))
     local_state_->SetBoolean(prefs::kAppLauncherHasBeenEnabled, false);
 
   if (command_line_.HasSwitch(switches::kEnableAppList))
     EnableAppList(initial_profile, ENABLE_VIA_COMMAND_LINE);
 
   if (!base::MessageLoop::current())
     return;  // In a unit test.
 
   // Send app list usage stats after a delay.
   const int kSendUsageStatsDelay = 5;
-  base::MessageLoop::current()->PostDelayedTask(
-      FROM_HERE,
-      base::Bind(&AppListServiceImpl::SendAppListStats),
+  base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+      FROM_HERE, base::Bind(&AppListServiceImpl::SendAppListStats),
       base::TimeDelta::FromSeconds(kSendUsageStatsDelay));
 }