runtime/vm/debugger_x64.cc - Issue 1160063002: Remove unused pc descriptor types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_x64.cc

Issue 1160063002: Remove unused pc descriptor types. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: added comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger_x64.cc

diff --git a/runtime/vm/debugger_x64.cc b/runtime/vm/debugger_x64.cc

index a2ca7a7c37bf227dee18014c9b0a1c421eb57e35..39b1ac115c4d6394810ac82f55521e1b1fb18a79 100644

--- a/runtime/vm/debugger_x64.cc

+++ b/runtime/vm/debugger_x64.cc

@@ -29,9 +29,6 @@ void CodeBreakpoint::PatchCode() {

case RawPcDescriptors::kUnoptStaticCall:

stub_target = stub_code->ICCallBreakpointEntryPoint();

break;

- case RawPcDescriptors::kClosureCall:

- stub_target = stub_code->ClosureCallBreakpointEntryPoint();

- break;

case RawPcDescriptors::kRuntimeCall:

stub_target = stub_code->RuntimeCallBreakpointEntryPoint();

break;

@@ -51,7 +48,6 @@ void CodeBreakpoint::RestoreCode() {

switch (breakpoint_kind_) {

case RawPcDescriptors::kIcCall:

case RawPcDescriptors::kUnoptStaticCall:

- case RawPcDescriptors::kClosureCall:

case RawPcDescriptors::kRuntimeCall: {

CodePatcher::PatchPoolPointerCallAt(pc_, code, saved_value_);

break;

« no previous file with comments | « runtime/vm/debugger_mips.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »