Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: build/common.gypi

Issue 1160033002: Enable template checking for the clang plugin on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2164 matching lines...) Expand 10 before | Expand all | Expand 10 after
2175 }], 2175 }],
2176 ], 2176 ],
2177 }, 2177 },
2178 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ', 2178 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ',
2179 }, { # OS == "win" 2179 }, { # OS == "win"
2180 # On Windows, the plugin is built directly into clang, so there's 2180 # On Windows, the plugin is built directly into clang, so there's
2181 # no need to load it dynamically. 2181 # no need to load it dynamically.
2182 'clang_dynlib_flags%': '', 2182 'clang_dynlib_flags%': '',
2183 }], 2183 }],
2184 # https://crbug.com/441916 2184 # https://crbug.com/441916
2185 ['OS=="linux"', { 2185 ['OS=="linux" or OS=="mac"', {
2186 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xc lang check-templates ', 2186 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xc lang check-templates ',
2187 }, { # OS != "linux" 2187 }, { # OS != "linux"
2188 'clang_plugin_args%': '' 2188 'clang_plugin_args%': ''
2189 }], 2189 }],
2190 ], 2190 ],
2191 }, 2191 },
2192 # If you change these, also change build/config/clang/BUILD.gn. 2192 # If you change these, also change build/config/clang/BUILD.gn.
2193 'clang_chrome_plugins_flags%': 2193 'clang_chrome_plugins_flags%':
2194 '<(clang_dynlib_flags)' 2194 '<(clang_dynlib_flags)'
2195 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' , 2195 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' ,
(...skipping 4008 matching lines...) Expand 10 before | Expand all | Expand 10 after
6204 # settings in target dicts. SYMROOT is a special case, because many other 6204 # settings in target dicts. SYMROOT is a special case, because many other
6205 # Xcode variables depend on it, including variables such as 6205 # Xcode variables depend on it, including variables such as
6206 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6206 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6207 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6207 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6208 # files to appear (when present) in the UI as actual files and not red 6208 # files to appear (when present) in the UI as actual files and not red
6209 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6209 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6210 # and therefore SYMROOT, needs to be set at the project level. 6210 # and therefore SYMROOT, needs to be set at the project level.
6211 'SYMROOT': '<(DEPTH)/xcodebuild', 6211 'SYMROOT': '<(DEPTH)/xcodebuild',
6212 }, 6212 },
6213 } 6213 }
OLDNEW
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698