Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1160033002: Enable template checking for the clang plugin on Mac. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable template checking for the clang plugin on Mac. This enables the plugin to check templated classes for the following things: - virtual functions have {virtual,override,final} correctly specified. - Refcounted types have private destructors. - WeakPtrFactory members are the last members BUG=441916 Committed: https://crrev.com/dcf757517b8b95793c0aff1509cb356cdcbd59e9 Cr-Commit-Position: refs/heads/master@{#331743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
It might work. It might not work. One way to find out! (I'm building locally ...
5 years, 7 months ago (2015-05-27 23:56:39 UTC) #2
Nico
lgtm
5 years, 6 months ago (2015-05-28 02:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160033002/1
5 years, 6 months ago (2015-05-28 03:30:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 05:21:46 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 05:22:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf757517b8b95793c0aff1509cb356cdcbd59e9
Cr-Commit-Position: refs/heads/master@{#331743}

Powered by Google App Engine
This is Rietveld 408576698