Issue 1160013007: Expose _remove from fn2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160013007: Expose _remove from fn2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Expose _remove from fn2 Turns out Scaffold needs to hook _remove, so we need to rename it to remove to expose it outside fn2.dart. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0f0528feed89ac080d59ca03953826fb686c829b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -16 lines)			Patch
	M	sky/sdk/lib/framework/components2/scaffold.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
	M	sky/sdk/lib/framework/fn2.dart	View		9 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-05 16:03:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f0528feed89ac080d59ca03953826fb686c829b (presubmit successful).