Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1160013007: Expose _remove from fn2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose _remove from fn2 Turns out Scaffold needs to hook _remove, so we need to rename it to remove to expose it outside fn2.dart. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0f0528feed89ac080d59ca03953826fb686c829b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 9 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-05 16:00:48 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-05 16:01:54 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-05 16:03:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f0528feed89ac080d59ca03953826fb686c829b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698