sky/sdk/lib/framework/rendering/node.dart - Issue 1160013004: Implement RenderImage and Image for Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/rendering/node.dart

Issue 1160013004: Implement RenderImage and Image for Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Implement code review feedback from Adam and improve demo Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/rendering/node.dart

diff --git a/sky/sdk/lib/framework/rendering/node.dart b/sky/sdk/lib/framework/rendering/node.dart

index 45ed33921cd079e73fd46d4e78433a78432923a4..cfeec1599ddcfe35ef32316a6f407fd5990a3e7d 100644

--- a/sky/sdk/lib/framework/rendering/node.dart

+++ b/sky/sdk/lib/framework/rendering/node.dart

@@ -229,6 +229,14 @@ abstract class RenderNodeWithChildMixin<ChildType extends RenderNode> {

adoptChild(_child);

markNeedsLayout();

}

+ void attachChildren() {

+ if (_child != null)

+ _child.attach();

+ }

+ void detachChildren() {

+ if (_child != null)

+ _child.detach();

+ }

abarth-chromium 2015/06/03 17:53:22 Ideally we'd have a test case that covers this bug

jackson 2015/06/03 22:06:26 Agree, I will investigate after landing this.

}