Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1160013004: Implement RenderImage and Image for Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Implement code review feedback from Adam and improve demo Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 427f58b47c82e416863c54e292ca106e3f27f14c..8ee9f46f8c9f2267940bbd69f7f96ee8a024e37e 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -613,18 +613,18 @@ class FlexExpandingChild extends ParentDataNode {
}
class Image extends RenderNodeWrapper {
- RenderCSSImage root;
- RenderCSSImage createNode() => new RenderCSSImage(this, this.src, this.width, this.height);
+ RenderImage root;
+ RenderImage createNode() => new RenderImage(this.src, this.size);
+
+ RenderNodeWrapper get emptyNode => _emptyImage;
abarth-chromium 2015/06/03 17:53:21 We don't need emptyNode anymore.
jackson 2015/06/03 22:06:26 Done.
final String src;
- final int width;
- final int height;
+ final sky.Size size;
Image({
Object key,
- this.width,
- this.height,
- this.src
+ this.src,
+ this.size
}) : super(key: key);
void syncRenderNode(UINode old) {

Powered by Google App Engine
This is Rietveld 408576698