Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1160013004: Implement RenderImage and Image for Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: CR feedback from Eric Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 427f58b47c82e416863c54e292ca106e3f27f14c..2ee1d46719d7c4ed4c28ec99c89b097d107257cc 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -13,6 +13,7 @@ import 'app.dart';
import 'rendering/block.dart';
import 'rendering/box.dart';
import 'rendering/flex.dart';
+import 'rendering/image.dart';
import 'rendering/node.dart';
import 'rendering/paragraph.dart';
@@ -613,12 +614,16 @@ class FlexExpandingChild extends ParentDataNode {
}
class Image extends RenderNodeWrapper {
- RenderCSSImage root;
- RenderCSSImage createNode() => new RenderCSSImage(this, this.src, this.width, this.height);
+ RenderImage root;
+ RenderImage createNode() => new RenderImage(this.src, this.width, this.height);
+
+ static final Image _emptyImage = new Image();
+
+ RenderNodeWrapper get emptyNode => _emptyImage;
final String src;
- final int width;
- final int height;
+ final double width;
+ final double height;
abarth-chromium 2015/06/03 00:16:31 These should be held as a sky.Size not separately
jackson 2015/06/03 17:41:43 Done.
Image({
Object key,

Powered by Google App Engine
This is Rietveld 408576698