Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1160013004: Implement RenderImage and Image for Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Clean up the example Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 9a4538bcaedaafaf69d554d8845b038f5f6974c5..65e68391c40834660965dab62ea45f48405f2cf8 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -13,6 +13,7 @@ import 'app.dart';
import 'rendering/render_block.dart';
import 'rendering/render_box.dart';
import 'rendering/render_flex.dart';
+import 'rendering/render_image.dart';
import 'rendering/render_node.dart';
import 'rendering/render_paragraph.dart';
@@ -545,12 +546,16 @@ class FlexExpandingChild extends ParentDataNode {
}
class Image extends RenderNodeWrapper {
- RenderCSSImage root;
- RenderCSSImage createNode() => new RenderCSSImage(this, this.src, this.width, this.height);
+ RenderImage root;
+ RenderImage createNode() => new RenderImage(this.src, this.width, this.height);
+
+ static final Image _emptyImage = new Image();
+
+ RenderNodeWrapper get emptyNode => _emptyImage;
abarth-chromium 2015/06/03 00:07:53 We don't need _emptyImage or emptyNode anymore.
jackson 2015/06/03 17:41:42 Acknowledged.
final String src;
- final int width;
- final int height;
+ final double width;
+ final double height;
Image({
Object key,

Powered by Google App Engine
This is Rietveld 408576698