Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160003004: small CL to experiment with 'disabling' memory mapping (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

small CL to experiment with 'disabling' memory mapping TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/2e48e1514396b363ecd19372eab637b11bfb8a82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/gpu/GrConfig.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
we may revert this if the impact is too great
5 years, 6 months ago (2015-05-28 16:10:20 UTC) #2
robertphillips
lgtm - worth a try.
5 years, 6 months ago (2015-05-28 17:21:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160003004/1
5 years, 6 months ago (2015-05-28 18:44:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/178)
5 years, 6 months ago (2015-05-28 18:45:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160003004/1
5 years, 6 months ago (2015-05-28 18:53:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2e48e1514396b363ecd19372eab637b11bfb8a82
5 years, 6 months ago (2015-05-28 18:53:55 UTC) #10
joshualitt
5 years, 6 months ago (2015-05-28 20:39:52 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1159133004/ by joshualitt@google.com.

The reason for reverting is: experiment complete.

Powered by Google App Engine
This is Rietveld 408576698