Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11600: * Rename to Irregexp throughout.... (Closed)

Created:
12 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

* Rename to Irregexp throughout. * Disable Irregexp by default. * Fix bug with trying to run a regexp that failed to compile. Committed: http://code.google.com/p/v8/source/detail?r=829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -1660 lines) Patch
M src/SConscript View 1 chunk +3 lines, -3 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/assembler-irregexp.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + src/assembler-irregexp.cc View 13 chunks +60 lines, -59 lines 0 comments Download
A + src/assembler-irregexp-inl.h View 4 chunks +6 lines, -6 lines 0 comments Download
D src/assembler-re2k.h View 1 chunk +0 lines, -137 lines 0 comments Download
D src/assembler-re2k.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D src/assembler-re2k-inl.h View 1 chunk +0 lines, -82 lines 0 comments Download
A + src/bytecodes-irregexp.h View 2 chunks +3 lines, -3 lines 0 comments Download
D src/bytecodes-re2k.h View 1 chunk +0 lines, -78 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +5 lines, -4 lines 0 comments Download
A + src/interpreter-irregexp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/interpreter-irregexp.cc View 2 chunks +7 lines, -7 lines 0 comments Download
D src/interpreter-re2k.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/interpreter-re2k.cc View 1 chunk +0 lines, -347 lines 0 comments Download
M src/jsregexp.h View 5 chunks +25 lines, -25 lines 0 comments Download
M src/jsregexp.cc View 19 chunks +88 lines, -73 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp-macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/regexp-macro-assembler-irregexp.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + src/regexp-macro-assembler-irregexp.cc View 6 chunks +54 lines, -49 lines 0 comments Download
D src/regexp-macro-assembler-re2k.h View 1 chunk +0 lines, -93 lines 0 comments Download
D src/regexp-macro-assembler-re2k.cc View 1 chunk +0 lines, -261 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -1 line 1 comment Download
M test/cctest/test-regexp.cc View 7 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
12 years, 1 month ago (2008-11-24 14:43:23 UTC) #1
Christian Plesner Hansen
12 years, 1 month ago (2008-11-24 14:52:02 UTC) #2
L-sort-of-gtm.

http://codereview.chromium.org/11600/diff/1/13
File src/runtime.cc (right):

http://codereview.chromium.org/11600/diff/1/13#newcode802
Line 802: return *RegExpImpl::ExecGlobal(regexp, subject);
What about this one?

Powered by Google App Engine
This is Rietveld 408576698