Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1159983010: Record root layer's position in its TransformNode (Closed)

Created:
5 years, 6 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 6 months ago
Reviewers:
Ian Vollick, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record root layer's position in its TransformNode Currently we only record non-root layer's position in the associated TransformNode. In practice, root layer might always be positioned at (0,0), so we might not be seeing the problem. But in tests we can manually set root layer to have non-zero position which will cause visible rects mismatch for property tree verification. One example is the unittest in this CL that root layer is positioned at (60, 70, 100x100). Viewport size is (0, 0, 100x100) in target space, so the visible rects of the root layer is clipped to be size 40x30. With the fix the unittest pass with property tree verification turned on. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9d3da5243ea13e8c057dac2b1a4d61285182eb11 Cr-Commit-Position: refs/heads/master@{#333109}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yufeng Shen (Slow to review)
5 years, 6 months ago (2015-06-04 22:36:08 UTC) #2
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-05 17:43:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159983010/20001
5 years, 6 months ago (2015-06-05 17:45:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 19:45:19 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:00:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d3da5243ea13e8c057dac2b1a4d61285182eb11
Cr-Commit-Position: refs/heads/master@{#333109}

Powered by Google App Engine
This is Rietveld 408576698