Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1159973002: Break GrTextContext's reliance on SkGpuDevice (Closed)

Created:
5 years, 7 months ago by robertphillips
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Break GrTextContext's reliance on SkGpuDevice This CL seems to have 2 main downsides: 1) It duplicates some code in SkBaseDevice::filterTextFlags 2) It makes it tougher to derive from SkGpuDevice It seems reasonable (at least to me) that the TextContexts get the power to reset the LCD flags. Committed: https://skia.googlesource.com/skia/+/9c240a1e6d314056fe0d6a8a33a3c60a6e19288f

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -33 lines) Patch
M src/gpu/GrAtlasTextContext.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 9 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/GrTextContext.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 chunks +32 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 7 months ago (2015-05-27 19:41:08 UTC) #2
bsalomon
lgtm. Re pt 2, I'd be happy to mark SkGpuDevice final. Can the SkGpuDevice stuff ...
5 years, 7 months ago (2015-05-27 20:39:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159973002/20001
5 years, 6 months ago (2015-05-28 11:57:00 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-28 12:02:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159973002/20001
5 years, 6 months ago (2015-05-28 14:45:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9c240a1e6d314056fe0d6a8a33a3c60a6e19288f
5 years, 6 months ago (2015-05-28 14:46:04 UTC) #10
robertphillips
5 years, 6 months ago (2015-05-28 14:47:07 UTC) #11
Message was sent while issue was closed.
The SkGpuDevice stuff in GrContext.h can't be removed until the TextContext is
behind the GrContext (so the SkGpuDevice won't be creating it).

Powered by Google App Engine
This is Rietveld 408576698