Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1159953009: Add droger as owner of //base/ios (Closed)

Created:
5 years, 6 months ago by droger
Modified:
5 years, 6 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, erikwright+watch_chromium.org, qsr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add droger as owner of //base/ios Committed: https://crrev.com/e515c840f7b6099cd5fa32b76912e1d7a9414b6b Cr-Commit-Position: refs/heads/master@{#333021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/ios/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
droger
I'd like to self-nominate for being an owner of //base/ios, let me know what you ...
5 years, 6 months ago (2015-06-04 13:05:28 UTC) #2
stuartmorgan
LGTM. Keep in mind that for base, always start by asking if the code really ...
5 years, 6 months ago (2015-06-04 13:43:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159953009/1
5 years, 6 months ago (2015-06-05 07:41:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 07:49:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 07:50:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e515c840f7b6099cd5fa32b76912e1d7a9414b6b
Cr-Commit-Position: refs/heads/master@{#333021}

Powered by Google App Engine
This is Rietveld 408576698