Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1159953004: [Chromoting] Do not initialize remoting.windowShape on CRD. (Closed)

Created:
5 years, 6 months ago by kelvinp
Modified:
5 years, 6 months ago
Reviewers:
garykac
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Do not initialize remoting.windowShape on CRD. Currently, a few components, e.g. remoting.Html5ModalDialog assumes that the current window is shaped and uses remoting.windowShape to handle its layout. This CL decouples those controls from remoting.windowShape so they can be used in CRD as well. Committed: https://crrev.com/9e1d8ee4cdf85f0c29cf3677f5394c7e92ccac0e Cr-Commit-Position: refs/heads/master@{#332099}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reviewer's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -36 lines) Patch
M remoting/webapp/app_remoting/js/app_connected_view.js View 1 3 chunks +7 lines, -5 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 4 chunks +9 lines, -3 lines 0 comments Download
M remoting/webapp/app_remoting/js/application_context_menu.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/webapp/app_remoting/js/context_menu_dom.js View 1 6 chunks +10 lines, -8 lines 0 comments Download
M remoting/webapp/app_remoting/js/idle_detector.js View 1 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/webapp/base/js/connection_dropped_dialog.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/webapp/base/js/connection_stats.js View 2 chunks +10 lines, -3 lines 0 comments Download
M remoting/webapp/base/js/modal_dialogs.js View 4 chunks +12 lines, -4 lines 0 comments Download
M remoting/webapp/base/js/window_shape.js View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kelvinp
PTAL
5 years, 6 months ago (2015-05-29 00:39:44 UTC) #2
garykac
https://codereview.chromium.org/1159953004/diff/1/remoting/webapp/base/js/window_shape.js File remoting/webapp/base/js/window_shape.js (right): https://codereview.chromium.org/1159953004/diff/1/remoting/webapp/base/js/window_shape.js#newcode152 remoting/webapp/base/js/window_shape.js:152: remoting.windowShape; If this is now being passed around, can ...
5 years, 6 months ago (2015-05-29 00:46:36 UTC) #3
kelvinp
Now window shape is not longer a global :) PTAL
5 years, 6 months ago (2015-05-29 22:14:09 UTC) #4
garykac
lgtm This looks great! Thank you!
5 years, 6 months ago (2015-05-29 22:21:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159953004/20001
5 years, 6 months ago (2015-05-30 00:13:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-30 01:56:09 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 01:57:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e1d8ee4cdf85f0c29cf3677f5394c7e92ccac0e
Cr-Commit-Position: refs/heads/master@{#332099}

Powered by Google App Engine
This is Rietveld 408576698