Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: public/platform/WebMemoryAllocatorDump.h

Issue 1159923006: [tracing] Expose AddOwnershipEdge and CreateAllocatorDump with guid to blink. (blink-side). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/Platform.h ('k') | public/platform/WebProcessMemoryDump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebMemoryAllocatorDump.h
diff --git a/public/platform/WebMemoryAllocatorDump.h b/public/platform/WebMemoryAllocatorDump.h
index a3c786290715ab70e57e4aeb3aaccf19d90ddadf..d57eab7e15dd7de6925f45943246a2d11cc7b000 100644
--- a/public/platform/WebMemoryAllocatorDump.h
+++ b/public/platform/WebMemoryAllocatorDump.h
@@ -9,6 +9,7 @@
#include "WebString.h"
namespace blink {
+typedef uint64_t WebMemoryAllocatorDumpGuid;
// A container which holds all the attributes of a particular dump for a given
// allocator.
@@ -27,6 +28,18 @@ public:
virtual void AddScalar(const char* name, const char* units, uint64_t value) { }
virtual void AddScalarF(const char* name, const char* units, double value) { }
virtual void AddString(const char* name, const char* units, const WebString& value) { }
+
+ // |guid| is an optional global dump identifier, unique across all processes
+ // within the scope of a global dump. It is only required when using the
+ // graph APIs (see AddOwnershipEdge) to express retention / suballocation or
+ // cross process sharing. See crbug.com/492102 for design docs.
+ // Subsequent MemoryAllocatorDump(s) with the same |absolute_name| are
+ // expected to have the same guid.
+ virtual WebMemoryAllocatorDumpGuid guid() const
+ {
+ BLINK_ASSERT_NOT_REACHED();
+ return 0;
+ }
};
} // namespace blink
« no previous file with comments | « public/platform/Platform.h ('k') | public/platform/WebProcessMemoryDump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698