Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1159853005: HttpServerProperties - Don't persist if SetSupportsSpdy is called with (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@persist_SET_SERVER_NETWORK_STATS
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HttpServerProperties - Don't persist if SetSupportsSpdy is called with the same origin (HostPortPair) and value (supports_spdy). This change reduces the number of times SetSupportsSpdy tries to persist HttpServerProperties to disk (currently ~5% of persist calls are due to SetSupportsSpdy). BUG=451256 R=rch@chromium.org Committed: https://crrev.com/e267d6a5e8f7fd198c4ac5d11d7098a1d17228c5 Cr-Commit-Position: refs/heads/master@{#333146}

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M net/http/http_server_properties.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159853005/1
5 years, 6 months ago (2015-05-29 00:20:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 00:26:02 UTC) #4
ramant (doing other things)
Hi Ryan, This is similar to other HttpServerProperties changes. Made the change for "SupportsSpdy". thanks ...
5 years, 6 months ago (2015-05-29 00:30:59 UTC) #5
ramant (doing other things)
On 2015/05/29 00:30:59, ramant wrote: > Hi Ryan, > This is similar to other HttpServerProperties ...
5 years, 6 months ago (2015-06-05 16:55:33 UTC) #6
ramant (doing other things)
PTAL. thanks raman
5 years, 6 months ago (2015-06-05 16:56:14 UTC) #7
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-05 20:32:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159853005/20001
5 years, 6 months ago (2015-06-05 21:49:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 21:55:30 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 21:56:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e267d6a5e8f7fd198c4ac5d11d7098a1d17228c5
Cr-Commit-Position: refs/heads/master@{#333146}

Powered by Google App Engine
This is Rietveld 408576698