Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 1159853003: fixing onSkipScanlines png error (Closed)

Created:
5 years, 7 months ago by emmaleer
Modified:
5 years, 7 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fixing onSkipScanlines png error There was a bug in onSkipScanlines where NULL was being passed instead of the SrcRow to png_read_rows. This caused SkipScanlines to appear to be skipping, as fCurrScanline was updated and SkipScanlines returned success, however png_read_rows was not actually reading anything, and no lines were skipped. Committed: https://skia.googlesource.com/skia/+/7dc9190b765d00467bed7076bacb568fb894e137

Patch Set 1 : fixing onSkipScanlines ong error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/codec/SkCodec_libpng.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
emmaleer
Fixed onSkipScanlines png error, which was passing null to png_read_rows instead of SrcRow.
5 years, 7 months ago (2015-05-26 22:24:29 UTC) #2
scroggo
lgtm
5 years, 7 months ago (2015-05-27 13:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159853003/1
5 years, 7 months ago (2015-05-27 15:43:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7dc9190b765d00467bed7076bacb568fb894e137
5 years, 7 months ago (2015-05-27 15:49:08 UTC) #6
scroggo
5 years, 7 months ago (2015-05-27 17:14:08 UTC) #7
Message was sent while issue was closed.
On 2015/05/27 15:49:08, I haz the power - commit-bot wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/7dc9190b765d00467bed7076bacb568fb894e137

For posterity, this was originally a part of
https://codereview.chromium.org/1134113006/

Powered by Google App Engine
This is Rietveld 408576698