Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1159803003: Add SIGHUP and SIGTERM handlers in NaCl. (Closed)

Created:
5 years, 7 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add SIGHUP and SIGTERM handlers in NaCl. When running NaCl code in a PID namespace, we need explicit handlers for signals that we might receive from outside the PID namespace, such as SIGTERM. This change installs a signal handler which exits by default. BUG= https://code.google.com/p/chromium/issues/detail?id=460972 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/3b1b3cf099145cf3db831f7f29a251ac071c5290

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/trusted/service_runtime/linux/nacl_signal.c View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
rickyz (no longer on Chrome)
Hi, here's the NaCl part of the changes to enable one PID namespace per process ...
5 years, 7 months ago (2015-05-27 05:18:48 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/1159803003/diff/1/src/trusted/service_runtime/linux/nacl_signal.c File src/trusted/service_runtime/linux/nacl_signal.c (right): https://codereview.chromium.org/1159803003/diff/1/src/trusted/service_runtime/linux/nacl_signal.c#newcode46 src/trusted/service_runtime/linux/nacl_signal.c:46: SIGHUP, SIGINT, SIGQUIT, SIGILL, SIGTRAP, SIGBUS, SIGFPE, SIGSEGV, ...
5 years, 6 months ago (2015-06-04 19:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159803003/1
5 years, 6 months ago (2015-06-04 22:19:25 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:42:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/3b1b3cf09...

Powered by Google App Engine
This is Rietveld 408576698