Object.observe: test mutating an object via the API

Object.observe: test mutating an object via the API

Committed: https://code.google.com/p/v8/source/detail?r=13246

[adamk, 2012-12-17 19:51:35]

Just testing Set/ForceSet/Delete/ForceDelete for now. Still to come are tests
for API-style Accessor properties and Interceptors (once I figure out more about
the behavior of those).

[rossberg, 2012-12-18 13:35:58]

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-api.cc#ol...
test/cctest/test-api.cc:85: static void ExpectString(const char* code, const
char* expected) {
For consistency, perhaps move the following Expect* functions to cctest.h as
well.

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-object-ob...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-object-ob...
test/cctest/test-object-observe.cc:309: ExpectString("records[0].type", "new");
Can you check object and oldValue as well? Perhaps via a helper function?

[adamk, 2012-12-18 17:26:10]

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-object-ob...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/11598014/diff/2001/test/cctest/test-object-ob...
test/cctest/test-object-observe.cc:309: ExpectString("records[0].type", "new");
On 2012/12/18 13:35:58, rossberg wrote:
> Can you check object and oldValue as well? Perhaps via a helper function?

Added a helper. Will do a cleanup in a future change to make more use of it/make
it better, but it suffices for this test.

[rossberg, 2012-12-19 10:31:30]

lgtm