Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: cc/layer_animation_controller.h

Issue 11598005: Ref count layer animation controllers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_animation_controller.h
diff --git a/cc/layer_animation_controller.h b/cc/layer_animation_controller.h
index be55afe38105cf46cf142caa893665f5254e3567..fab2a1ac0bb1ea748de81f7163ec01c43fc94fc9 100644
--- a/cc/layer_animation_controller.h
+++ b/cc/layer_animation_controller.h
@@ -7,10 +7,14 @@
#include "base/basictypes.h"
#include "base/hash_tables.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/observer_list.h"
+#include "base/time.h"
#include "cc/animation_events.h"
#include "cc/cc_export.h"
#include "cc/scoped_ptr_vector.h"
+#include "ui/gfx/transform.h"
namespace gfx {
class Transform;
@@ -19,24 +23,23 @@ class Transform;
namespace cc {
class Animation;
+class AnimationRegistrar;
class KeyframeValueList;
-class CC_EXPORT LayerAnimationControllerClient {
+class CC_EXPORT LayerAnimationControllerObserver {
public:
- virtual ~LayerAnimationControllerClient() { }
+ virtual ~LayerAnimationControllerObserver() { }
- virtual int id() const = 0;
- virtual void setOpacityFromAnimation(float) = 0;
- virtual float opacity() const = 0;
- virtual void setTransformFromAnimation(const gfx::Transform&) = 0;
- virtual const gfx::Transform& transform() const = 0;
+ virtual void OnOpacityAnimated(float) = 0;
+ virtual void OnTransformAnimated(const gfx::Transform&) = 0;
};
-class CC_EXPORT LayerAnimationController {
+class CC_EXPORT LayerAnimationController
+ : public base::RefCounted<LayerAnimationController> {
public:
- static scoped_ptr<LayerAnimationController> create(LayerAnimationControllerClient*);
+ static scoped_refptr<LayerAnimationController> create(int id);
- virtual ~LayerAnimationController();
+ int id() const { return m_id; }
// These methods are virtual for testing.
virtual void addAnimation(scoped_ptr<ActiveAnimation>);
@@ -75,10 +78,16 @@ public:
// thread, all animations will be transferred.
void setForceSync() { m_forceSync = true; }
- void setClient(LayerAnimationControllerClient*);
+ void setAnimationRegistrar(AnimationRegistrar*);
+
+ void addObserver(LayerAnimationControllerObserver*);
+ void removeObserver(LayerAnimationControllerObserver*);
protected:
- explicit LayerAnimationController(LayerAnimationControllerClient*);
+ friend class base::RefCounted<LayerAnimationController>;
+
+ LayerAnimationController(int id);
+ virtual ~LayerAnimationController();
private:
typedef base::hash_set<int> TargetProperties;
@@ -97,12 +106,23 @@ private:
void tickAnimations(double monotonicTime);
+ void updateActivation(bool force = false);
+
+ void notifyObserversOpacityAnimated(float opacity);
+ void notifyObserversTransformAnimated(const gfx::Transform& transform);
+
// If this is true, we force a sync to the impl thread.
bool m_forceSync;
- LayerAnimationControllerClient* m_client;
+ AnimationRegistrar* m_registrar;
+ int m_id;
ScopedPtrVector<ActiveAnimation> m_activeAnimations;
+ // This is used to ensure that we don't spam the registrar.
+ bool m_isActive;
+
+ ObserverList<LayerAnimationControllerObserver> m_observers;
+
DISALLOW_COPY_AND_ASSIGN(LayerAnimationController);
};

Powered by Google App Engine
This is Rietveld 408576698