Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(55)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1159793005: Deprecated webkit-prefixed properties of the Touch interface. (Closed)

Created:
4 years, 11 months ago by mustaq
Modified:
4 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, sof, arv+blink, vivekg, vivekg_samsung, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, rwlbuis, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecated webkit-prefixed properties of the Touch interface. Deprecated webkit-prefixed properties of the Touch interface: webkitRadiusX, webkitRadiusY, webkitRotationAngle and webkitForce, in favor of the unprefixed versions. The prefixed ones will be removed in M47. BUG=460099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196350

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 10 (4 generated)
mustaq
ptal
4 years, 11 months ago (2015-06-02 19:59:20 UTC) #4
philipj_slow
LGTM % nit https://codereview.chromium.org/1159793005/diff/40001/LayoutTests/fast/events/touch/document-create-touch.html File LayoutTests/fast/events/touch/document-create-touch.html (left): https://codereview.chromium.org/1159793005/diff/40001/LayoutTests/fast/events/touch/document-create-touch.html#oldcode38 LayoutTests/fast/events/touch/document-create-touch.html:38: shouldBe("touch.webkitRadiusX", "5"); Please leave the prefixed ...
4 years, 11 months ago (2015-06-02 20:09:18 UTC) #5
mustaq
https://codereview.chromium.org/1159793005/diff/40001/LayoutTests/fast/events/touch/document-create-touch.html File LayoutTests/fast/events/touch/document-create-touch.html (left): https://codereview.chromium.org/1159793005/diff/40001/LayoutTests/fast/events/touch/document-create-touch.html#oldcode38 LayoutTests/fast/events/touch/document-create-touch.html:38: shouldBe("touch.webkitRadiusX", "5"); On 2015/06/02 20:09:18, philipj wrote: > Please ...
4 years, 11 months ago (2015-06-02 20:18:03 UTC) #6
philipj_slow
Even more LGTM!
4 years, 11 months ago (2015-06-02 20:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159793005/60001
4 years, 11 months ago (2015-06-02 21:15:08 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 22:36:42 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196350

Powered by Google App Engine
This is Rietveld 408576698