Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1159773005: Handle border-image with fill and zero-width borders (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove newly added but flaky test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index f668620b095015648d489dd76352b72f812f59c8..306fccde90b11b663dcd9c15ea4222a3c1286940 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -689,7 +689,7 @@ LayoutFlowThread* LayoutObject::locateFlowThreadContainingBlock() const
// FIXME: This is incorrect for document element. Remove this when we enable slimming paint.
static inline bool layoutObjectHasNoBoxEffectObsolete(const LayoutObject& object)
{
- return !object.style()->hasVisualOverflowingEffect() && !object.style()->hasBorder() && !object.style()->hasBackground();
+ return !object.style()->hasVisualOverflowingEffect() && !object.style()->hasBorderDecoration() && !object.style()->hasBackground();
}
bool LayoutObject::skipInvalidationWhenLaidOutChildren() const
@@ -1668,7 +1668,7 @@ StyleDifference LayoutObject::adjustStyleDifference(StyleDifference diff) const
}
if (diff.textOrColorChanged() && !diff.needsPaintInvalidation()) {
- if (style()->hasBorder() || style()->hasOutline()
+ if (style()->hasBorderDecoration() || style()->hasOutline()
pdr. 2015/06/02 03:07:56 I think this may be correct as just hasBorder beca
davve 2015/06/03 06:56:01 Ah, sounds reasonable. Thanks.
|| (isText() && !toLayoutText(this)->isAllCollapsibleWhitespace()))
diff.setNeedsPaintInvalidationObject();
}

Powered by Google App Engine
This is Rietveld 408576698